Skip to content

Sidebar not hiding when a menu link is clicked on mobile view #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bot101 opened this issue Jun 18, 2018 · 2 comments
Closed

Sidebar not hiding when a menu link is clicked on mobile view #13

bot101 opened this issue Jun 18, 2018 · 2 comments

Comments

@bot101
Copy link

bot101 commented Jun 18, 2018

The sidebar does not auto-hide on mobile view when any of the menu links are clicked, and the user has to click the hamburger to hide the menu. That doesn't make for good user experience. Also, the current structure of the template doesn't make modifications to the sidebar (apart from styling) easier because of how its currently bundled as a node dependency. Making it a standalone component or module that can be easily modified to correct issues like this one would be a great idea. Thank you for a great template!!
xidedix added a commit that referenced this issue Jun 18, 2018
@xidedix
fix: hide mobile sidebar issue #13
8feb2f7
@xidedix xidedix mentioned this issue Jun 18, 2018
Merged
xidedix added a commit that referenced this issue Jun 18, 2018
@xidedix
Merge pull request #14 from coreui/fix-hide-mobile-sidebar
d77504f 
fix: hide mobile sidebar issue #13
@xidedix xidedix mentioned this issue Jun 19, 2018
Merged
@xidedix
Copy link
Member

xidedix commented Jun 19, 2018

v2.0.0-rc.1 fixes: Sidebar not hiding when a menu link is clicked on mobile view

@bot101
Copy link
Author

bot101 commented Jun 19, 2018 •
edited
Loading

Thanks for the feedback and fix

@bot101 bot101 closed this as completed Jun 19, 2018
damingerdai added a commit to damingerdai/coreui-angular that referenced this issue Sep 1, 2021
@damingerdai
Merge pull request coreui#13 from damingerdai/dependabot/npm_and_yarn…
6f20eed 
…/fstream-1.0.12

build(deps): bump fstream from 1.0.11 to 1.0.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bot101 @xidedix