Skip to content

not compiling with angular 8 #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jrocha opened this issue Mar 4, 2020 · 1 comment
Closed

not compiling with angular 8 #103

jrocha opened this issue Mar 4, 2020 · 1 comment

Comments

@jrocha
Copy link
Contributor

jrocha commented Mar 4, 2020

Due to breaking changes on TypeScript 3.7 (link) it's not possible to use this lib using Angular 8.

If you try to use it you get the following compilation errors:

ERROR in node_modules/@coreui/angular/lib/sidebar/app-sidebar-nav/app-sidebar-nav-items.component.d.ts:11:9 - error TS1086: An accessor cannot be declared in an ambient context.
11     set items(items: INavData[]);
           ~~~~~
node_modules/@coreui/angular/lib/sidebar/app-sidebar-nav/app-sidebar-nav-items.component.d.ts:12:9 - error TS1086: An accessor cannot be declared in an ambient context.
12     get items(): INavData[];
           ~~~~~
node_modules/@coreui/angular/lib/sidebar/app-sidebar-nav/app-sidebar-nav-link.component.d.ts:15:9 - error TS1086: An accessor cannot be declared in an ambient context.
15     set item(item: INavData);
           ~~~~
node_modules/@coreui/angular/lib/sidebar/app-sidebar-nav/app-sidebar-nav-link.component.d.ts:16:9 - error TS1086: An accessor cannot be declared in an ambient context.
16     get item(): INavData;
           ~~~~
node_modules/@coreui/angular/lib/sidebar/app-sidebar.component.d.ts:13:9 - error TS1086: An accessor cannot be declared in an ambient context.
13     get minimized(): boolean;
           ~~~~~~~~~
node_modules/@coreui/angular/lib/sidebar/app-sidebar.component.d.ts:14:9 - error TS1086: An accessor cannot be declared in an ambient context.
14     set minimized(value: boolean);
           ~~~~~~~~~

Environment details:

Angular CLI: 8.3.23
Node: 12.14.0
OS: win32 x64
Angular: 8.2.14
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.803.23
@angular-devkit/build-angular     0.803.23
@angular-devkit/build-optimizer   0.803.23
@angular-devkit/build-webpack     0.803.23
@angular-devkit/core              8.3.23
@angular-devkit/schematics        8.3.23
@angular/cdk                      8.2.3
@angular/cli                      8.3.23
@ngtools/webpack                  8.3.23
@schematics/angular               8.3.23
@schematics/update                0.803.23
rxjs                              6.4.0
typescript                        3.5.3
webpack                           4.39.2

@xidedix
Copy link
Member

xidedix commented Mar 5, 2020

#104 merged - thanks @jrocha

to fix the issue, update @coreui/angular to 2.9.1

@xidedix xidedix closed this as completed Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants