Skip to content

chore: remove unused configs #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 11, 2020
Merged

chore: remove unused configs #991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5e3d269
chore: remove no longer used travis config
armano2 Feb 10, 2020
b9264e4
chore: remove lodash resolution to have environment as users
armano2 Feb 10, 2020
b473370
chore(commitlint-config-patternplate): move utils to devDependencies
armano2 Feb 10, 2020
6381148
chore(read): remove no longer used babel config
armano2 Feb 10, 2020
0c7640f
chore: remove redundant workspaces-experimental yarn flag
armano2 Feb 10, 2020
138f9ea
Revert "chore: remove lodash resolution to have environment as users"
armano2 Feb 10, 2020
e3e3bb9
Merge branch 'master' into chore/packages
armano2 Feb 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .travis.yml
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion .yarnrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
workspaces-experimental "true"
Copy link
Contributor Author

@armano2 armano2 Feb 10, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting Yarn 1.0 Workspaces are enabled by default and you may not need to set the below config. Refer to the updated steps at the following location https://yarnpkg.com/lang/en/docs/workspaces/

2017/08/02

https://classic.yarnpkg.com/blog/2017/08/02/introducing-workspaces/#setting-up-workspaces

off-topic: they released/releasing v2 of yarn

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we might have a look. Last I checked the ts interop was not great

registry "https://registry.npmjs.org/"
--install.ignore-engines true
4 changes: 3 additions & 1 deletion @alias/commitlint-config-patternplate/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@
"node": ">=8"
},
"dependencies": {
"@commitlint/config-patternplate": "^8.3.4",
"@commitlint/config-patternplate": "^8.3.4"
},
"devDependencies": {
"@commitlint/utils": "^8.3.4"
Comment on lines 31 to 35
Copy link
Contributor Author

@armano2 armano2 Feb 10, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no reason to require utils when installing config,

utils is a dev package

}
}
8 changes: 0 additions & 8 deletions @commitlint/read/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,6 @@
"deps": "dep-check",
"pkg": "pkg-check --skip-import"
},
"babel": {
"presets": [
"babel-preset-commitlint"
],
"ignore": [
"**/*.test.js"
]
},
Comment on lines -14 to -21
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i missed this one last time

"engines": {
"node": ">=8"
},
Expand Down