-
Notifications
You must be signed in to change notification settings - Fork 934
refactor(cli): port cli to typescript #978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6ddc1a1
to
00304bc
Compare
@@ -114,7 +114,7 @@ export type QualifiedRules = Partial<RulesConfig<RuleConfigQuality.Qualified>>; | |||
export interface QualifiedConfig { | |||
extends: string[]; | |||
formatter: unknown; | |||
rules: Partial<QualifiedRules>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QualifiedRules
is already Partial
seems that linux build is failing due to: |
f02aacb
to
5d6fb5e
Compare
yargs has built in feature of producing help:
|
for now i'v done simple migration, but we could move most of args validations to yargs |
4488113
to
6fea4cf
Compare
it seems that you did some mistakes while doing rebase |
e869e16
to
712f4cd
Compare
@armano2 thanks so much for all your efforts! ❤️ |
Description
Part of #659
At first i wanted to just migrate it without refactoring, but as [email protected] has horrible type and v6 (current) is just a wrapper for yargs (with horrible types) than we can use yargs directly to reduce complexity.
while reviewing i do recommend to disable whitespaces as diff is getting way more readable
https://github.com/conventional-changelog/commitlint/pull/978/files?utf8=✓&diff=split&w=1
Motivation and Context
Ported cli to typescript as part of #659
How Has This Been Tested?Types of changes
Checklist: