Skip to content

chore: remove unused eslint-disable comments #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Feb 7, 2020

remove unused eslint-disable comments

Description

Motivation and Context

Usage examples

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@armano2
Copy link
Contributor Author

armano2 commented Feb 7, 2020

do we want to have eslint running in this project?

issue from #971 was reported by eslint in my local env

@marionebl
Copy link
Contributor

do we want to have eslint running in this project?

I am not against it if we keep the rules to the bare bug-catching minimum. So no import-ordering or other bikeshedding rules. Do you have a good preset for this?

@marionebl marionebl merged commit c44adfd into conventional-changelog:master Feb 7, 2020
@armano2 armano2 deleted the eslint-comments branch February 7, 2020 11:04
@armano2 armano2 mentioned this pull request Feb 8, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants