refactor(commitlint): simplify commitlint alias package #965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armano2
commented
Feb 6, 2020
|
|
||
| require(bin); | ||
| const pkgDir = require('@commitlint/cli'); | ||
| require(pkgDir); |
There was a problem hiding this comment.
this can be even simpler as we can directly import
require('@commitlint/cli/lib/cli');
There was a problem hiding this comment.
Good call on the simplification. Let's keep the current solution to maintain a degree of decoupling so we can move around the the commitlint bin file inside of @commitlint/cli if we want to.
armano2
commented
Feb 6, 2020
| const actual = await cli(['--verbose'], {cwd}, 'type: bar'); | ||
| expect(actual.stdout).toContain('0 problems, 0 warnings'); | ||
| expect(actual.stderr).toEqual(''); | ||
| }); |
There was a problem hiding this comment.
i'm unsure if we really need tests for this
There was a problem hiding this comment.
Quick smoke tests are in order via #889
marionebl
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify commitlint alias package and add tests for it
Description
Motivation and Context
Remove unnecessary dependencies
Usage examples
How Has This Been Tested?
Types of changes
Checklist: