Skip to content

refactor: replace unmaintained sander package with fs-extra #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 5, 2020

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Feb 5, 2020

replace unmaintained sander package with fs-extra #918

Description

Motivation and Context

sander package seems unmaintained (not updated for 4 years) and cli is only place where is used.
sander has no type definition

fs promisify and utils.promisify is not supported in targeted node versions (this should be replaced if/when node 8 / 10 will is going to be targeted)

Usage examples

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marionebl marionebl changed the title test(cli): replace unmaintained sander package with fs-extra refactor: replace unmaintained sander package with fs-extra Feb 5, 2020
@marionebl marionebl merged commit 35661f3 into conventional-changelog:master Feb 5, 2020
@armano2 armano2 deleted the remove-dev-sander branch February 5, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants