test(travis-cli): migrate tests from ava to jest #910
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,9 @@ | ||
| #!/usr/bin/env node | ||
|
|
||
| const args = process.argv; | ||
| args.shift(); // remove node | ||
|
There was a problem hiding this comment. we don't want to output node as arg as its just making issues, and it let me remove |
||
| console.log( | ||
| args.map((item, index) => { | ||
| return index === 0 ? 'commitlint' : item; | ||
|
There was a problem hiding this comment. this solves command test result being system depended |
||
| }) | ||
| ); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,9 @@ | ||
| #!/usr/bin/env node | ||
|
|
||
| const args = process.argv; | ||
| args.shift(); // remove node | ||
| console.log( | ||
| args.map((item, index) => { | ||
| return index === 0 ? 'git' : item; | ||
| }) | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,218 +1,114 @@ | ||
| import execa from 'execa'; | ||
| import {git} from '@commitlint/test'; | ||
|
|
||
| const bin = require.resolve('../lib/cli.js'); | ||
|
|
||
| const TRAVIS_COMMITLINT_BIN = require.resolve('../fixtures/commitlint'); | ||
| const TRAVIS_COMMITLINT_GIT_BIN = require.resolve('../fixtures/git'); | ||
|
|
||
| const validBaseEnv = { | ||
| TRAVIS: true, | ||
| CI: true, | ||
| TRAVIS_COMMIT: 'TRAVIS_COMMIT', | ||
| TRAVIS_COMMITLINT_BIN: TRAVIS_COMMITLINT_BIN, | ||
| TRAVIS_COMMITLINT_GIT_BIN: TRAVIS_COMMITLINT_GIT_BIN, | ||
| TRAVIS_COMMIT_RANGE: 'TRAVIS_COMMIT_A.TRAVIS_COMMIT_B', | ||
| TRAVIS_EVENT_TYPE: 'TRAVIS_EVENT_TYPE', | ||
| TRAVIS_REPO_SLUG: 'TRAVIS_REPO_SLUG', | ||
| TRAVIS_PULL_REQUEST_SLUG: 'TRAVIS_PULL_REQUEST_SLUG' | ||
| }; | ||
|
|
||
| const cli = async (config = {}) => { | ||
| try { | ||
| return await execa(bin, [], config); | ||
| } catch (err) { | ||
| throw new Error([err.stdout, err.stderr].join('\n')); | ||
| } | ||
| }; | ||
|
|
||
| test('should throw when not on travis ci', async () => { | ||
| const env = { | ||
| CI: false, | ||
| TRAVIS: false | ||
| }; | ||
|
|
||
| await expect(cli({env})).rejects.toThrow( | ||
| '@commitlint/travis-cli is intended to be used on Travis CI' | ||
| ); | ||
| }); | ||
|
|
||
| test('should throw when on travis ci, but env vars are missing', async () => { | ||
| const env = { | ||
| TRAVIS: true, | ||
| CI: true | ||
| }; | ||
|
|
||
| await expect(cli({env})).rejects.toThrow( | ||
| 'TRAVIS_COMMIT, TRAVIS_COMMIT_RANGE, TRAVIS_EVENT_TYPE, TRAVIS_REPO_SLUG, TRAVIS_PULL_REQUEST_SLUG' | ||
| ); | ||
| }); | ||
|
|
||
| test('should call git with expected args', async () => { | ||
| const cwd = await git.clone( | ||
| 'https://github.com/conventional-changelog/commitlint.git', | ||
| ['--depth=10'], | ||
| __dirname, | ||
| TRAVIS_COMMITLINT_GIT_BIN | ||
| ); | ||
|
|
||
| const result = await cli({ | ||
| cwd, | ||
| env: validBaseEnv | ||
| }); | ||
| const invocations = await getInvocations(result.stdout); | ||
| expect(invocations.length).toBe(3); | ||
|
|
||
| const [stash, branches, commilint] = invocations; | ||
|
|
||
| expect(stash).toEqual(['git', 'stash', '-k', '-u', '--quiet']); | ||
| expect(branches).toEqual(['git', 'stash', 'pop', '--quiet']); | ||
| expect(commilint).toEqual(['commitlint']); | ||
| }); | ||
|
|
||
| test('should call git with expected args on pull_request', async () => { | ||
| const cwd = await git.clone( | ||
| 'https://github.com/conventional-changelog/commitlint.git', | ||
| ['--depth=10'], | ||
| __dirname, | ||
| TRAVIS_COMMITLINT_GIT_BIN | ||
| ); | ||
|
|
||
| const result = await cli({ | ||
| cwd, | ||
| env: {...validBaseEnv, TRAVIS_EVENT_TYPE: 'pull_request'} | ||
| }); | ||
| const invocations = await getInvocations(result.stdout); | ||
| expect(invocations.length).toBe(3); | ||
|
|
||
| const [stash, branches, commilint] = invocations; | ||
|
|
||
| expect(stash).toEqual(['git', 'stash', '-k', '-u', '--quiet']); | ||
| expect(branches).toEqual(['git', 'stash', 'pop', '--quiet']); | ||
| expect(commilint).toEqual([ | ||
| 'commitlint', | ||
| '--from', | ||
| 'TRAVIS_COMMIT_A', | ||
| '--to', | ||
| 'TRAVIS_COMMIT_B' | ||
| ]); | ||
| }); | ||
|
|
||
| function getInvocations(stdout) { | ||
| const matches = stdout.match(/[^[\]]+/g); | ||
| const raw = Array.isArray(matches) ? matches : []; | ||
|
|
||
| return raw | ||
| .filter(invocation => invocation !== '\n') | ||
| .map(invocation => | ||
| invocation | ||
| .split(',') | ||
| .map(fragment => fragment.trim()) | ||
| .map(fragment => fragment.substring(1, fragment.length - 1)) | ||
| .filter(Boolean) | ||
| ); | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small update here, this is a little cleaner way to get correct path for all env