Skip to content

fix(config-lerna): support lerna > 2.4 #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2017
Merged

Conversation

marionebl
Copy link
Contributor

@marionebl marionebl commented Oct 9, 2017

@marionebl
Copy link
Contributor Author

@QuentinRoy
Copy link
Contributor

QuentinRoy commented Oct 10, 2017

As it seems this is relying on some unstable part of lerna, I was wondering if it might be a good idea to specify lerna's version (in the dependencies) as strict (i.e. without the ^, e.g. 2.4.x). Doing this would almost always result in a second version of lerna being installed, but would significantly reduce the risk for this package to suddenly fail on new versions of lerna.

@marionebl
Copy link
Contributor Author

This indeed relies on currently undocumented internal lerna API. I plan on asking the lerna project to publish some of it, did not come around to do that yet.

I changed config-lerna to pick up the lerna version used by the project, so pinning our own devDependency (will have to move lerna to that for config-lerna) would not achieve better stability.

I'd keep it in its current state (optimised for guaranteed equivalence of pkg listings) for now.

@marionebl marionebl deleted the quentionroy/master branch October 14, 2017 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants