-
Notifications
You must be signed in to change notification settings - Fork 933
fix: update lodash to 4.17.11 to fix vulenrabilities #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
5bf44eb
e6535c4
6955a2e
498f9be
dba99ae
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -73,6 +73,7 @@ | |
}, | ||
"dependencies": { | ||
"babel-runtime": "^6.23.0", | ||
"chalk": "^2.0.1" | ||
"chalk": "^2.0.1", | ||
"lodash": "^4.17.11" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -72,6 +72,7 @@ | |
"@commitlint/load": "^7.2.1", | ||
"babel-runtime": "^6.23.0", | ||
"chalk": "^2.0.0", | ||
"lodash": "^4.17.11", | ||
"lodash.camelcase": "4.3.0", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also some old lodash modules right? 😄 |
||
"lodash.kebabcase": "4.1.1", | ||
"lodash.snakecase": "4.1.1", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -75,6 +75,7 @@ | |
}, | ||
"dependencies": { | ||
"babel-runtime": "6.26.0", | ||
"lodash": "^4.17.11", | ||
"lodash.merge": "4.6.1", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's burn the lodash modules! 😬 |
||
"lodash.omit": "4.5.0", | ||
"require-uncached": "^1.0.3", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -78,6 +78,7 @@ | |
"@commitlint/ensure": "^7.2.0", | ||
"@commitlint/message": "^7.1.2", | ||
"@commitlint/to-lines": "^7.1.2", | ||
"babel-runtime": "^6.23.0" | ||
"babel-runtime": "^6.23.0", | ||
"lodash": "^4.17.11" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here, I found lodash.values in the dev-dependencies. I would say, remove that one and move lodash to devdependencies 😄 |
||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this package, lodash is used as devdependency. I think it's best to keep it there (and remove the old lodash.includes of course 😄