[docs] Fix Husky setup instructions #428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escapedcat
reviewed
Sep 3, 2018
| @@ -48,12 +48,13 @@ echo "module.exports = {extends: ['@commitlint/config-conventional']}" > commitl | |||
| ``` | |||
|
|
|||
|
|
|||
| To lint commits before they are created you can use the 'commitmsg' hook as described [here](https://github.com/typicode/husky/blob/master/HOOKS.md#hooks) | |||
|
|
|||
| To lint commits before they are created you can use Husky's 'commit-msg' hook: | |||
There was a problem hiding this comment.
Why removing the link to https://github.com/typicode/husky/blob/master/HOOKS.md#hooks ?
And:
[...] you can use Husky's 'commit-msg' hook
In the code it's commitmsg not commit-msg. That might be confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #366
Motivation and Context
#366
Usage examples
How Has This Been Tested?
Types of changes
Checklist:
My change requires a change to the documentation.I have added tests to cover my changes.