Skip to content

docs: use RuleConfigSeverity in config docs #3521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tehraninasab
Copy link
Contributor

Description

There is the following enum for checking rule config severity in commitlint/@commitlint/types/src/rules that we should use in typescript plugins instead of 0, 1, and 2 numbers to make the code clearer.

export enum RuleConfigSeverity {
	Disabled = 0,
	Warning = 1,
	Error = 2,
}

Motivation and Context

To make the docs clearer.

How Has This Been Tested?

It has been used in our local plugins.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

There is the following enum for checking rule config severity
in `commitlint/@commitlint/types/src/rules` that we should use
in typescript plugins instead of 0, 1, and 2 numbers to make
the code clearer.

```
export enum RuleConfigSeverity {
	Disabled = 0,
	Warning = 1,
	Error = 2,
}
```
@tehraninasab tehraninasab changed the title commitlint: use RuleConfigSeverity in config docs docs: use RuleConfigSeverity in config docs Feb 4, 2023
@tehraninasab tehraninasab force-pushed the use-RuleConfigSeverity-in-documentation branch from 881ccb5 to fc3d4bd Compare February 4, 2023 10:23
Copy link
Member

@escapedcat escapedcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoop whoop, thanks!

@escapedcat escapedcat merged commit b3007ee into conventional-changelog:master Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants