fix(rules): do not negate case rules #330
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change
subject-case
rule on config-conventional and config-angular to non-negating rules.Motivation and Context
Many scripts, i.e. Han, Devanagari, are not cased. Thus
ensureCase
will always return true for texts written in these scripts on any case rules.Negating case rules will cause
test: 你好
as invalid since they are conformed to any case rules.For definition of cased, see http://unicode.org/reports/tr44/#Cased
Usage examples
How Has This Been Tested?
Types of changes
Checklist:
Further plans for discussion
Deprecate the use of
never
on case rules aswith