fix(platform): windows installation #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### 1. Summary Fix installation syntax for Windows. Curly braces syntax [**doesn't work**](https://stackoverflow.com/a/38876970/5951529) for Windows-specific terminals. ### 2. Behavior before pull request ```node D:\SashaDemoRepositories\SashaCommitlint>npm install --save-dev @commitlint/{config-conventional,cli} npm ERR! code ENOLOCAL npm ERR! Could not install from "@commitlint\{config-conventional,cli}" as it does not contain a package.json file. npm ERR! A complete log of this run can be found in: npm ERR! C:\Users\SashaChernykh\AppData\Roaming\npm-cache\_logs\2018-04-10T13_23_19_766Z-debug.log ``` ### 3. Behavior after pull request ```node D:\SashaDemoRepositories\SashaCommitlint>npm install --save-dev @commitlint/config-conventional @commitlint/cli + @commitlint/[email protected] + @commitlint/[email protected] added 170 packages from 61 contributors in 34.977s ``` ### 4. Testing environment + Windows 10 Enterprise LTSB 64-bit EN, + Node.js 9.11.1, + npm 5.8.0, + [**Clink**](https://mridgers.github.io/clink/) 0.4.8. Thanks.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Summary
Fix installation syntax for Windows.
Curly braces syntax doesn't work for Windows-specific terminals.
2. Behavior before pull request
3. Behavior after pull request
4. Testing environment
Thanks.