Skip to content

feat: add bitbucket merge commits to ignore list #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2018
Merged

feat: add bitbucket merge commits to ignore list #304

merged 1 commit into from
Mar 2, 2018

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Mar 2, 2018

This PR is related to issue #60 and this comment.

Description

This adds two types of Bitbucket merge commits to the ignore list, which are generated by Bitbucket itself. It should allow all Bitbucket users to use the default message without the linter going berserk on these messages.

Motivation and Context

We at Peakfijn definitely want to use this tool. But since we are using Bitbucket all of our projects raises false positives on the default merge messages.

Usage examples

The following commands should now pass without failing.

$ echo "Merged in feature/facebook-friends-sync (pull request #8)" | commitlint
$ echo "Merged develop into feature/component-form-select-card" | commitlint

How Has This Been Tested?

I added these exact messages to the test file with a proper description about Bitbucket.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marionebl
Copy link
Contributor

LGTM, merging as the Node.js 4 build appears to be stalled.

@marionebl
Copy link
Contributor

Thanks!

@marionebl marionebl merged commit ddb470c into conventional-changelog:master Mar 2, 2018
@byCedric
Copy link
Member Author

byCedric commented Mar 2, 2018

No problem, thanks for merging. The node 4 stall is related to the currently degraded performance, I'm experiencing it with other project too... Thanks again! 😄

@byCedric byCedric deleted the feature/ignore-bitbucket-merges branch March 2, 2018 14:23
@marionebl
Copy link
Contributor

Released via 6.1.3

@byCedric
Copy link
Member Author

byCedric commented Mar 2, 2018

Yes, currently implementing it in a future project at work! Thanks a lot, works like a charm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants