Skip to content

test(load): use installModules instead of npm install #2431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2021
Merged

test(load): use installModules instead of npm install #2431

merged 1 commit into from
Jan 29, 2021

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Jan 29, 2021 •
edited
Loading

Description

expose helper function installModules to ease test time and timeouts on windows machines

this change removes ~5sec from tests on my machine

Motivation and Context

constant timeout on windows during development

npm/npm#21148

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@armano2
test(load): use installModules instead of npm install
b649186 
expose helper function installModules to ease test time and timeouts on windows machines

npm/npm#21148
@escapedcat escapedcat merged commit 8ee0e9e into conventional-changelog:master Jan 29, 2021
@armano2 armano2 deleted the test/load branch January 29, 2021 04:55
tim-stasse pushed a commit to tim-stasse/commitlint that referenced this pull request Feb 8, 2021
@armano2 @tim-stasse
test(load): use installModules instead of npm install (conventional-c…
d3c6735 
…hangelog#2431)

expose helper function installModules to ease test time and timeouts on windows machines

npm/npm#21148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armano2 @escapedcat