Skip to content

docs: pre-commit -> commit-msg for Husky v5 #2372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2020
Merged

docs: pre-commit -> commit-msg for Husky v5 #2372

merged 1 commit into from
Dec 18, 2020

Conversation

oebrab
Copy link
Contributor

@oebrab oebrab commented Dec 17, 2020

See this PR in husky's repo.

@escapedcat
Copy link
Member

Thanks @oebrab !
Hey @Manubi , can you confirm this?

@Manubi
Copy link
Contributor

Manubi commented Dec 17, 2020

hey!
commit-msg_—_impfi-frontend
pre-commit_—_impfi-frontend

@escapedcat
Copy link
Member

escapedcat commented Dec 18, 2020 •
edited
Loading

Thanks @Manubi ! This PR will fix this, right?: https://github.com/conventional-changelog/commitlint/pull/2340/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R117

Sorry, just to make sure to understand this :) If you both agree we can merge this.

@Manubi
Copy link
Contributor

Manubi commented Dec 18, 2020

Looks good to me. :)

@escapedcat
Copy link
Member

:D Thanks @Manubi and @oebrab !

@escapedcat escapedcat merged commit 7edef12 into conventional-changelog:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oebrab @escapedcat @Manubi