Skip to content

docs: add vidavidorra/commitlint-plugin-function-rules project #2224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2020
Merged

docs: add vidavidorra/commitlint-plugin-function-rules project #2224

merged 1 commit into from
Oct 21, 2020

Conversation

jdbruijn
Copy link
Contributor

Plugin to use functions as rule value.

Description

Add commitlint plugin function rules as community project.

@escapedcat As per your suggestion in #1698 (comment). I've kept it in the same style as the commitlint.io project.

Motivation and Context

Add my project.

Usage examples

n/a

How Has This Been Tested?

n/a

Types of changes

Not actually a bug fix but docs update, so I guess this type 😉

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@escapedcat
Copy link
Member

Looks good I think. Later on we could give plugins their own section or deal with it differently.

I just don't have a clue why - only on your PRs - the checks always look this:
image
You have any idea? It's the same on your types-PR.

@jdbruijn
Copy link
Contributor Author

You have any idea?

I honestly have no idea. I indeed noticed the same on my other PR, but thought nothing about it at that time. I've just forked this repo, made my changes, pushed them and then created a PR here. I do the same steps for other projects and haven't run into any issues there. I even checked whether there were any branch protection rules on my fork, but there aren't, not that I think that should make any difference.

@escapedcat
Copy link
Member

Haha, yeah, it's weird.
@byCedric any idea?

@jdbruijn
Copy link
Contributor Author

I obviously can't see the settings, but found these topics on the issue.

I also have the WIP GitHub app installed on my side on all repositories, also doubt that would be an issue, but I've disabled that for now to check. I'll also try to push a new commit to try and trigger the checks. I did check the branch naming, but doubt that is it as other PR's use similar naming, e.g. ellsclytn:feat/help-url-in-config.

@jdbruijn
Copy link
Contributor Author

Okay, this interesting. The checks are pending now. Maybe it had to do with the WIP, although very odd that something that I have installed could mess with the checks on this organisation. Might try to verify by enabling WIP again later today and force pushing again. If that is indeed the case I'll contact GitHub support about it.

image

@jdbruijn
Copy link
Contributor Author

jdbruijn commented Oct 21, 2020

Weird, I enabled WIP again and force pushed again to check, but now passed. So I don't know what was going on, I still suspect something with WIP.

Anyhow, the tests are now working, and have passed.

@escapedcat
Copy link
Member

Thanks a lot for teh digging @jdbruijn ! Weird stuff. Will merge.

@escapedcat escapedcat merged commit 5a13468 into conventional-changelog:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants