Skip to content

Specify correct node version format in package.json #2139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

xomaczar
Copy link
Contributor

@xomaczar xomaczar commented Sep 21, 2020

Description

Drop v prefix from node's version in package.json

Motivation and Context

Some tools (e.g. voltajs) does not recognize the node version format.

How Has This Been Tested?

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Specify correct version of node commitlint supports.
@xomaczar xomaczar changed the title Specify correct node version in packages.json Specify correct node version format in packages.json Sep 21, 2020
@xomaczar xomaczar changed the title Specify correct node version format in packages.json Specify correct node version format in package.json Sep 21, 2020
@escapedcat escapedcat merged commit 32007f9 into conventional-changelog:master Sep 22, 2020
@escapedcat
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants