Skip to content

fix: run prettier fixes from docker #2027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2020

Conversation

byCedric
Copy link
Member

Description

Fixes the files, running from Docker. Should solve Circle CI issues.

@byCedric byCedric requested a review from escapedcat July 25, 2020 12:11
@escapedcat
Copy link
Member

Thanks! So these are extra changes coming from format-fix being run within docker? And these didn't show up or were not made locally on my machine? How can that happen? Shouldn't it be the same?

@escapedcat escapedcat merged commit f228405 into chore/prettier-2.x Jul 26, 2020
@escapedcat escapedcat deleted the @bycedric/chore/prettier-2.x branch July 26, 2020 05:14
escapedcat added a commit that referenced this pull request Jul 26, 2020
* chore: update dependency prettier to v2

* chore: update prettier to v2.x

* chore: apply prettier v2.x format fixes

* chore: only run all circle-ci tasks on node LTS

* fix: run prettier fixes from docker (#2027)

Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Cedric van Putten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants