Skip to content

chore: use non-fixed lerna version #2026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2020
Merged

chore: use non-fixed lerna version #2026

merged 1 commit into from
Jul 28, 2020

Conversation

escapedcat
Copy link
Member

@escapedcat escapedcat commented Jul 25, 2020 •
edited
Loading

  • switch config to reflect v3 usage
  • use maypr versions for peerdeps

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@escapedcat
chore: use non-fixed lerna version
2c06adb 
- switch config to reflect v3 usage
- use maypr versions for peerdeps
@escapedcat escapedcat force-pushed the chore/lerna-non-fixed branch from 074f7b4 to 2c06adb Compare July 25, 2020 06:54
@escapedcat escapedcat requested review from marionebl and byCedric and removed request for marionebl July 25, 2020 07:03
byCedric
byCedric approved these changes Jul 25, 2020
View reviewed changes
Copy link
Member

@byCedric byCedric left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 I don't think the fixtures have a big effect, but the root repo upgrade is awesome!

@escapedcat
Copy link
Member Author

I didn't upgrade anything. If I understand it correctly we used v3 and only kept v2 for testing purposes in the package.json. Or did I miss something? Your comment made this look bigger than it should be :D

@byCedric
Copy link
Member

Haha, no I meant the package.json files in the tests, e.g. @commitlint/config-lerna-scopes/fixtures/basic/package.json

@escapedcat
Copy link
Member Author

:D Alright. Just wanted to generalise this. I'll merge this in.

@escapedcat escapedcat merged commit 1784ef2 into master Jul 28, 2020
@escapedcat escapedcat deleted the chore/lerna-non-fixed branch July 28, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byCedric byCedric byCedric approved these changes

@marionebl marionebl Awaiting requested review from marionebl

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@escapedcat @byCedric