Skip to content

docs: update README.md #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2020
Merged

docs: update README.md #1004

merged 1 commit into from
Jun 13, 2020

Conversation

xiaojianzhong
Copy link
Contributor

@xiaojianzhong xiaojianzhong commented Feb 22, 2020

Correct extend's name.

Motivation and Context

The installed extend is @commitlint/angular while the required extend is @commitlint/conventional.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@escapedcat
Copy link
Member

Thanks for noticing! According to the docs it should be this I guess:

npm install --save-dev @commitlint/{cli,config-conventional,prompt-cli}
echo "module.exports = {extends: ['@commitlint/config-conventional']};" > commitlint.config.js

What do you think?

Correct installed dependencies.
@xiaojianzhong
Copy link
Contributor Author

Okay, i have replaced @commitlint/config-angular with @commitlint/config-conventional by force pushing.

@escapedcat escapedcat requested a review from byCedric February 27, 2020 02:37
@escapedcat escapedcat merged commit 0e2ac30 into conventional-changelog:master Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants