Feature request: support more options for scope-case rule #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

navarroaxel opened this issue Sep 5, 2017 · 6 comments

Labels

feature

navarroaxel commented Sep 5, 2017

Hi! I want camelCase as scope-case rule. I think we can use lodash to avoid coding. Like:

https://lodash.com/docs/4.17.4#camelCase
https://lodash.com/docs/4.17.4#kebabCase
https://lodash.com/docs/4.17.4#snakeCase

And, we could throw an error if an invalid option is set? I think defaulting to lowercase is not good.

If you think that this approach is ok, I can try to make a PR with this feature.

Best.-

Contributor

marionebl commented Sep 5, 2017

The addition makes sense, let's add it.

Some comments.

Let's stick with the current default to avoid breaking changes

Rules that should support new cases

Cases to support

camelCase
PascalCase
kebab-case
snake_case
Start Case

A PR would be awesome!

Author

navarroaxel commented Sep 11, 2017

The options should be on kebab-case (ex. present-imperative) or camelCase (ex. lowerCase)?

Examples taken from @commitlint/config-angular.

Contributor

marionebl commented Sep 11, 2017

Let's go with kebab-case, but continue support for lowerCase, upperCase.

Contributor

marionebl commented Oct 3, 2017

Will land via https://github.com/marionebl/commitlint/pull/84

Contributor

marionebl commented Oct 3, 2017

Will release with 4.0 in the next days

marionebl added the feature label

Contributor

marionebl commented Oct 4, 2017

Released via 4.0! 🚀

marionebl closed this as completed

bpedersen pushed a commit to bpedersen/commitlint that referenced this issue


          chore(deps): bump handlebars from 4.1.1 to 4.1.2 (conventional-change…

d5d6bd7

…log#70)

Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.1.1 to 4.1.2.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md)
- [Commits](handlebars-lang/handlebars.js@v4.1.1...v4.1.2)

Signed-off-by: dependabot[bot] <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment