Skip to content

use with PR messages #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tomdavidson opened this issue May 2, 2017 · 2 comments · Fixed by #36
Closed

use with PR messages #35

tomdavidson opened this issue May 2, 2017 · 2 comments · Fixed by #36

Comments

@tomdavidson
Copy link

This is not necessarily a conventional-changelog-lint concern but I would like to use conventional-changelog-lint to link PR commit messages before code is merged ... and reject the PR if the message fails linting.

GIt does not have a pre-merge hook - any other conventional-changelog-lint users looking at the same that might have pointers?
marionebl added a commit that referenced this issue May 3, 2017
@marionebl
docs: add recipe for linting of all commits in a PR
7e02727 
* be more explicit / guide more than #24
* closes #35
* connected to #12
This was referenced May 3, 2017
Merged
Merged
marionebl added a commit that referenced this issue May 3, 2017
@marionebl
docs: add recipe for linting of all commits in a PR
09aecc2 
* be more explicit / guide more than #24
* closes #35
* connected to #12
@marionebl
Copy link
Contributor

Good question, thanks for that. I invested some work in the docs, could you have a look at readme.md?

Does this clear things up?

Also there is an example on how to do this at scripts/lint:commit.sh now.

marionebl added a commit that referenced this issue May 3, 2017
@marionebl
docs: add recipe for linting of all commits in a PR
28da35c 
* be more explicit / guide more than #24
* closes #35
* connected to #12
marionebl added a commit that referenced this issue May 4, 2017
@marionebl
docs: add recipe for linting of all commits in a PR (#36)
1e69d54 
* be more explicit / guide more than #24
* closes #35
* connected to #12
@marionebl
Copy link
Contributor

Closing this for now, feel free to reopen if the new docs do not help

@tomdavidson tomdavidson mentioned this issue May 8, 2017
Closed
marionebl added a commit that referenced this issue Jul 7, 2017
@marionebl
docs: add recipe for linting of all commits in a PR (#36)
f5fabf8 
* be more explicit / guide more than #24
* closes #35
* connected to #12
marionebl added a commit that referenced this issue Jul 10, 2017
@marionebl
docs: add recipe for linting of all commits in a PR (#36)
ad35602 
* be more explicit / guide more than #24
* closes #35
* connected to #12
marionebl added a commit that referenced this issue Jul 10, 2017
@marionebl
docs: add recipe for linting of all commits in a PR (#36)
71a4401 
* be more explicit / guide more than #24
* closes #35
* connected to #12
marionebl added a commit that referenced this issue Jul 11, 2017
@marionebl
docs: add recipe for linting of all commits in a PR (#36)
62e74b4 
* be more explicit / guide more than #24
* closes #35
* connected to #12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: add recipe for linting of all commits in a PR conventional-changelog/commitlint
2 participants
@tomdavidson @marionebl