Skip to content

Change the word 'missing' to 'invalid' #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
maoziliang opened this issue Apr 5, 2018 · 2 comments · Fixed by #440
Closed

Change the word 'missing' to 'invalid' #313

maoziliang opened this issue Apr 5, 2018 · 2 comments · Fixed by #440
Labels
enhancement good first issue help wanted

Comments

@maoziliang
Copy link

maoziliang commented Apr 5, 2018 •
edited
Loading

https://github.com/marionebl/commitlint/blob/86c34f10344a905fd51dd580860640e44930dfe9/%40commitlint/lint/src/index.js#L38

missing here is obscure. I think the the word invalid is much easier to understand.

Found invalid rule names
@marionebl
Copy link
Contributor

Sure, let's change this. Want to help with this?

@maoziliang
Copy link
Author

Okay, I plan to submit the PR next week

@byCedric byCedric mentioned this issue Sep 10, 2018
Merged
7 tasks
@dalisoft dalisoft mentioned this issue Dec 24, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(lint): use invalid instead of missing for unknown rules
2 participants
@maoziliang @marionebl