Skip to content

BUG: Breaking Change message can't be pushed #2379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 4 tasks
dalisoft opened this issue Dec 24, 2020 · 7 comments
Closed
2 of 4 tasks

BUG: Breaking Change message can't be pushed #2379

dalisoft opened this issue Dec 24, 2020 · 7 comments
Labels

Comments

@dalisoft
Copy link

dalisoft commented Dec 24, 2020

Expected Behavior

echo -e 'BREAKING CHANGE: baz' | yarn commitlint
yarn run v1.22.10
$ /Users/dalisoft/Desktop/Open_Source/nanoexpress/core/pro-slim/node_modules/.bin/commitlint
✨  Done in 0.50s.

Current Behavior

echo -e 'BREAKING CHANGE: baz' | yarn commitlint
yarn run v1.22.10
$ /Users/dalisoft/Desktop/Open_Source/nanoexpress/core/pro-slim/node_modules/.bin/commitlint
⧗   input: BREAKING CHANGE: baz
✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]

✖   found 2 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Affected packages

  • cli
  • core
  • prompt
  • config-angular

Possible Solution

It's not solution, a like workaround, using any of valid enum before breaking change.

echo -e 'fix(pkg): foo bar\n\nBREAKING CHANGE: baz' | yarn commitlint
yarn run v1.22.10
$ /Users/dalisoft/Desktop/Open_Source/nanoexpress/core/pro-slim/node_modules/.bin/commitlint
✨  Done in 0.50s.

Steps to Reproduce (for bugs)

  1. Install commitlint and configuration

  2. Try echo -e 'BREAKING CHANGE: baz' | yarn commitlint command

  3. First step

  4. Second step

commitlint.config.js
{
  "extends": [
    "airlight"
  ]
}

Context

Your Environment

Executable Version
commitlint --version @commitlint/[email protected]
git --version 2.29.2
node --version v15.5.0
@escapedcat
Copy link
Member

Thanks, how is this related to #313?

@escapedcat escapedcat added the bug label Dec 31, 2020
@dalisoft
Copy link
Author

@escapedcat sorry, seems i misspelled or linked invalid related issue

@nerdgore
Copy link

Related to this issue: If you're using the exclamation mark in the subject to denote a breaking change the linting will also fail.

Works

echo -e 'feat(node): new feature (PROJ-123)' | yarn commitlint 

Fails

echo -e 'feat(node)!: new feature (PROJ-123)' | yarn commitlint
⧗   input: feat(node)!: new feature (PROJ-123)
✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]
✖   references may not be empty [references-empty]

✖   found 3 problems, 0 warnings

@escapedcat
Copy link
Member

This is somewhat related as well I guess: #2226

@AdeAttwood
Copy link
Member

@escapedcat are we happy to get this one closed. For more info on the rule, you can refer to the angular config readme.

https://github.com/conventional-changelog/commitlint/tree/master/%40commitlint/config-angular#subject-exclamation-mark

@escapedcat
Copy link
Member

escapedcat commented Jul 13, 2021

Will be published with the v13 release

@beamery-tomht
Copy link

v13 didn't fix it for me. #2226 (comment) this worked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

5 participants