-
Notifications
You must be signed in to change notification settings - Fork 931
BUG: Breaking Change message can't be pushed #2379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks, how is this related to #313? |
@escapedcat sorry, seems i misspelled or linked invalid related issue |
Related to this issue: If you're using the exclamation mark in the subject to denote a breaking change the linting will also fail. Works echo -e 'feat(node): new feature (PROJ-123)' | yarn commitlint Fails › echo -e 'feat(node)!: new feature (PROJ-123)' | yarn commitlint
⧗ input: feat(node)!: new feature (PROJ-123)
✖ subject may not be empty [subject-empty]
✖ type may not be empty [type-empty]
✖ references may not be empty [references-empty]
✖ found 3 problems, 0 warnings |
This is somewhat related as well I guess: #2226 |
@escapedcat are we happy to get this one closed. For more info on the rule, you can refer to the angular config readme. |
Will be published with the v13 release |
v13 didn't fix it for me. #2226 (comment) this worked |
Uh oh!
There was an error while loading. Please reload this page.
Expected Behavior
Current Behavior
Affected packages
Possible Solution
It's not solution, a like workaround, using any of valid enum before breaking change.
Steps to Reproduce (for bugs)
Install
commitlint
and configurationTry
echo -e 'BREAKING CHANGE: baz' | yarn commitlint
commandFirst step
Second step
commitlint.config.js
Context
Your Environment
commitlint --version
@commitlint/[email protected]
git --version
2.29.2
node --version
v15.5.0
The text was updated successfully, but these errors were encountered: