Skip to content

Docs: body-case condition incorrectly described #2919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thernstig opened this issue Dec 14, 2021 · 7 comments
Closed

Docs: body-case condition incorrectly described #2919

thernstig opened this issue Dec 14, 2021 · 7 comments

Comments

@thernstig
Copy link

https://commitlint.js.org/#/reference-rules?id=body-case says:

condition: header is in case value

It should really say:

condition: body is in case value

@escapedcat
Copy link
Member

Hey @thernstig, thanks for opening this!
Are you interested to create a PR for this?

@MadhaviMandalia
Copy link
Contributor

Hello @escapedcat ,
Can I send PR for this?

Thanks & Regards.

@escapedcat
Copy link
Member

@MadhaviMandalia sure, please go ahead! Let me know if you need support or have questions

@MadhaviMandalia
Copy link
Contributor

@escapedcat thanks for replying.

If there is any other change please let me know, this change is already done in reference-rules.md. If there is no change I will raise a PR.

Thanks.

@escapedcat
Copy link
Member

Alright, thanks!
Looks like this hasn't been fixed:
https://github.com/conventional-changelog/commitlint/blob/master/docs/reference-rules.md

image

MadhaviMandalia added a commit to MadhaviMandalia/commitlint that referenced this issue Jan 3, 2022
`condition: header is in case value` changed to `condition: body is in case value`.
@MadhaviMandalia
Copy link
Contributor

@escapedcat I was asking because if there is any other changes I could commit all together 😄

@escapedcat
Copy link
Member

Ah sorry, not that I'm aware of, no. Thank you!

escapedcat pushed a commit that referenced this issue Jan 3, 2022
`condition: header is in case value` changed to `condition: body is in case value`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants