Allow for no, none, etc as answers to Breaking Changes #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

jimthedev opened this issue May 15, 2017 · 0 comments · Fixed by #58

Member

jimthedev commented May 15, 2017

Either we need to accept no, none, etc or have a better message to indicate that no is the default answer if you hit enter at the breaking changes prompt.

This discussion prompted by this Twitter convo: https://twitter.com/commitizen/status/863195437498609666

jlengstorf added a commit to jlengstorf/cz-conventional-changelog that referenced this issue


          feat(prompts): add confirm and clarify language

9f037c6

Breaking changes and issues now have confirm fields to ensure answers like "no" and "n/a" don’t
accidentally create breaking changes. Updated language around scopes to be less confusing for
non-Angular devs. Added examples for issue references/closing.

fix commitizen#52

jlengstorf mentioned this issue

feat(prompt): add confirmation fields + edit for clarity #58

Merged

jimthedev closed this as completed in #58

jimthedev pushed a commit that referenced this issue


          feat(prompt): add confirmation fields + edit for clarity (#58)

d40ac2c

* chore(config): switch czConfig to config

* feat(prompts): add confirm and clarify language

Breaking changes and issues now have confirm fields to ensure answers like "no" and "n/a" don’t
accidentally create breaking changes. Updated language around scopes to be less confusing for
non-Angular devs. Added examples for issue references/closing.

fix #52

* fix(engine): remove unhandled Promise rejection handler

This was for debugging and should not have been committed.

* refactor: clean up grammar and punctuation

simon-watiau pushed a commit to simon-watiau/cz-conventional-changelog that referenced this issue


          feat(prompt): add confirmation fields + edit for clarity (commitizen#58)

19a0a0e

* chore(config): switch czConfig to config

* feat(prompts): add confirm and clarify language

Breaking changes and issues now have confirm fields to ensure answers like "no" and "n/a" don’t
accidentally create breaking changes. Updated language around scopes to be less confusing for
non-Angular devs. Added examples for issue references/closing.

fix commitizen#52

* fix(engine): remove unhandled Promise rejection handler

This was for debugging and should not have been committed.

* refactor: clean up grammar and punctuation

github-actions bot pushed a commit to DawChihLiou/cz-conventional-changelog-with-jiraid-detection that referenced this issue


          chore(release): 1.0.0 [skip ci]

e10c25d

# 1.0.0 (2020-09-16)

### Bug Fixes

* **adapter:** Fix typo in etc. ([39182b8](39182b8))
* **build:** Add proper deps, force republish to make sure things are working ([922097b](922097b))
* **build:** Automatic releases!!! ✨ ([114f967](114f967))
* update longest to ^2 ([commitizen#88](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/88)) ([7234529](7234529))
* **commit:** Remove es6 string syntax (backticks) ([7f922f2](7f922f2))
* **commit:** remove parentheses when there is no scope present ([55f72b9](55f72b9))
* **config-loader:** captured the direct dependency on commitizen for the use of the config loader ([commitizen#90](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/90)) ([4b23bbc](4b23bbc)), closes [commitizen#89](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/89)
* **defaultValues:** Added fallback for optional default values ([commitizen#99](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/99)) ([2aae317](2aae317))
* **package.json:** install missing dependency ([4287211](4287211))
* **package.json:** update package name ([2985968](2985968))
* **prompter:** resolve issue with new inquirer api ([commitizen#18](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/18)) ([807b4e5](807b4e5))
* Correct typo in JSON ([58df4d1](58df4d1))
* **release:** attempt to fix release ([c167fd8](c167fd8))
* **release.config.js:** attempt to fix semantic release ([e362f9a](e362f9a))
* **require:** get rid of relative path to the word-wrap ([e98818a](e98818a)), closes [commitizen#4](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/4)
* **wrapping:** Fix fields to wrap instead of truncate at 100 characters ([c7b7e11](c7b7e11)), closes [commitizen/cz-cli#4](commitizen/cz-cli#4)
* remove pre-node 10 support ([commitizen#86](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/86)) ([76588ad](76588ad))
* Update conventional-commit-types to the latest version 🚀 ([commitizen#105](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/105)) ([5a371c1](5a371c1))
* Wrap updateTypes in packageRules ([0f6dfbf](0f6dfbf))

### Features

* **adapter:** Create initial commit. ([4e8da01](4e8da01))
* **adapter:** refactor to engine, default to conventional commit types ([c8452d1](c8452d1)), closes [commitizen#29](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/29)
* **adapter:** Split breaking changes into separate question ([commitizen#44](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/44)) ([2d78e1d](2d78e1d)), closes [commitizen#17](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/17)
* add default values to options ([commitizen#69](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/69)) ([65d6a9f](65d6a9f))
* implement configuration through package.json ([commitizen#75](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/75)) ([3398c02](3398c02))
* **engine:** add support for disableScopeLowerCase ([commitizen#96](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/96)) ([e7bd546](e7bd546))
* **engine:** add support for disableSubjectLowerCase ([df66875](df66875))
* **engine.js:** add jira step ([b6c6bfb](b6c6bfb))
* **prompt:** add confirmation fields + edit for clarity ([commitizen#58](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/58)) ([d40ac2c](d40ac2c)), closes [commitizen#52](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/52)
* **types:** add suport for custom types ([commitizen#104](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/104)) ([aae2548](aae2548))

### BREAKING CHANGES

* Node 10 is LTS so please upgrade to it.
* **adapter:** Breaking changes now automatically include the "BREAKING CHANGE: " prefix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment