-
Notifications
You must be signed in to change notification settings - Fork 555
commitizen uses wrong version of cz-conventional-changelog #478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I've also tried ./node_modules/.bin/git-cz
[email protected], [email protected] |
although this is the documented suggestion for configuration, i don't understand how it would have ever worked to put the configuration in a since the priority of config files gives
i noticed this inconsistency a long time ago when i first started using |
since package.json was prioritized first, it is always found and always used, even if it does not contain commitizen config. the other optional config files are never found as a result. this change looks for the optional files first and only lands on the package.json if the other files do not exist fixes commitizen#478
…les (#484) since package.json was prioritized first, it is always found and always used, even if it does not contain commitizen config. the other optional config files are never found as a result. this change looks for the optional files first and only lands on the package.json if the other files do not exist fixes #478
This Pull Request updates dependency [commitizen](https://github.com/commitizen/cz-cli) from `v2.9.6` to `v2.10.1` **Note**: This PR was created on a configured schedule ("before 3am on Monday") and will not receive updates outside those times. <details> <summary>Release Notes</summary> ### [`v2.10.1`](https://github.com/commitizen/cz-cli/releases/v2.10.1) [Compare Source](commitizen/cz-cli@v2.10.0...v2.10.1) <a name"2.10.1"></a> ##### 2.10.1 (2018-05-24) ##### Bug Fixes * **cli:** Respect git commit -a original behavior (#​376) (#​471) ([d10c94f4](commitizen/cz-cli@d10c94f4)) * **config:** prioritized package.json last when looking for config files (#​484) ([5f8902e7](commitizen/cz-cli@5f8902e7), closes [#​478](`https://github.com/commitizen/cz-cli/issues/478`)) --- ### [`v2.10.0`](https://github.com/commitizen/cz-cli/releases/v2.10.0) [Compare Source](commitizen/cz-cli@v2.9.6...v2.10.0) <a name"2.10.0"></a> #### 2.10.0 (2018-05-24) ##### Bug Fixes * lodash Node Security warning (#​482) ([0023958e](commitizen/cz-cli@0023958e)) * **adapter:** Don't print git root to stdout (#​428) ([d5e24245](commitizen/cz-cli@d5e24245)) * **cli:** Don't print error stack trace if git-cz failed (#​436) (#​437) ([53719a42](commitizen/cz-cli@53719a42)) ##### Features * **strategies:** respect the `--allow-emtpy` flag (#​477) ([495437c1](commitizen/cz-cli@495437c1)) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).
Uh oh!
There was an error while loading. Please reload this page.
In my
package.json
:<projectDir>/.czrc
:Then I run
npm run cz
(it is just simplygit-cz
) and get these questions:Questions about breaking changes and issues are combined into one, but I googled, that in one of the new releases of
cz-conventional-changelog
this behaviour was changed - commitizen/cz-conventional-changelog#44Ok, let's grep old combined message
And some code from related pull request
Then I noticed debug messages from
commitizen
:Why does it use 1.2.0, while I have 2.1.0 in
./node_modules/cz-conventional-changelog
?It turns out that
commitizen
uses wrong version ofcz-conventional-changelog
- it own version, but not installed by myself.Can you please help me with this strange behaviour ?
Thanks in advance
The text was updated successfully, but these errors were encountered: