Skip to content

async validation rules #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 12, 2020
Merged

async validation rules #21

merged 2 commits into from
Dec 12, 2020

Conversation

EranNL
Copy link
Contributor

@EranNL EranNL commented Dec 10, 2020

No description provided.

@EranNL EranNL marked this pull request as ready for review December 12, 2020 14:02
@EranNL EranNL changed the title Draft: async validation rules async validation rules Dec 12, 2020
@codecov
Copy link

codecov bot commented Dec 12, 2020

Codecov Report

Merging #21 (c19437b) into develop (25c017e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop       #21   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9        11    +2     
  Lines          256       278   +22     
  Branches        69        71    +2     
=========================================
+ Hits           256       278   +22     
Impacted Files Coverage Δ
__tests__/common/tick.ts 100.00% <100.00%> (ø)
src/Validator.ts 100.00% <100.00%> (ø)
src/components/ValidatorArea.tsx 100.00% <100.00%> (ø)
src/rules/activeUrl.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25c017e...c19437b. Read the comment docs.

@EranNL EranNL merged commit 8d83579 into develop Dec 12, 2020
@EranNL EranNL deleted the feature/async-validation branch December 12, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant