Skip to content

Theme update #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 7, 2024
Merged

Theme update #138

merged 4 commits into from
Nov 7, 2024

Conversation

GurinderRawala
Copy link
Contributor

No description provided.

@GurinderRawala GurinderRawala requested a review from a team as a code owner November 7, 2024 15:44
Copy link
Contributor

coderabbitai bot commented Nov 7, 2024

Walkthrough

The changes in this pull request primarily involve updates to the docusaurus.config.ts and src/css/custom.css files. The configuration file sees modifications in the navbar logo paths to enhance visual representation, including the addition of a dark theme logo. The CSS file introduces new font imports and updates to several CSS variables, significantly altering the site's typography and color scheme for both light and dark themes. Overall, these changes are cosmetic and focus on improving the aesthetic aspects of the Docusaurus site.

Changes

File Path Change Summary
docusaurus.config.ts Updated logo source paths in the navbar configuration: changed src to img/logo/bw_coderabbit.svg and added srcDark for dark theme support. Configuration for algolia search service remains unchanged.
src/css/custom.css Added imports for "Poppins" and "Work Sans" fonts. Updated multiple CSS variables under :root and in the dark theme section, changing color values for various primary color variables. Introduced --ifm-font-family-base for base font family.

Poem

In the garden of code, we hop and play,
With colors brightening up the day.
A logo new, a font so fine,
Our Docusaurus shines, oh how it twines!
Through dark and light, we dance with glee,
A vibrant site, for all to see! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 5d3daa8 and 1288ae3.

⛔ Files ignored due to path filters (3)
  • static/img/favicon.ico is excluded by !**/*.ico, !**/*.ico
  • static/img/logo/bw_coderabbit.svg is excluded by !**/*.svg, !**/*.svg
  • static/img/logo/white_coderabbit.svg is excluded by !**/*.svg, !**/*.svg
📒 Files selected for processing (1)
  • src/css/custom.css (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/css/custom.css

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

cloudflare-workers-and-pages bot commented Nov 7, 2024

Deploying coderabbit-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1288ae3
Status: ✅  Deploy successful!
Preview URL: https://970bbe3c.coderabbit-docs.pages.dev
Branch Preview URL: https://new-theme-colors-and-logo-c.coderabbit-docs.pages.dev

View logs

@GurinderRawala GurinderRawala force-pushed the new-theme-colors-and-logo-c branch from 221699f to 5d3daa8 Compare November 7, 2024 15:54
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Outside diff range and nitpick comments (2)
src/css/custom.css (2)

31-37: Ensure consistent color hierarchy in dark theme.

The dark theme color progression seems inconsistent:

  • Colors go from 50% opacity (#ff865b80) to solid (#ff865b)
  • The lightest color (#171717) is actually very dark, which seems counterintuitive
    Consider maintaining a more logical progression in the color scale.
-  --ifm-color-primary-lightest: #171717;
+  --ifm-color-primary-lightest: #ff865b0d;

Line range hint 45-156: Remove duplicated CSS blocks.

Several CSS blocks are duplicated in the file:

  • .navbar .navbar__item styles
  • Mobile view adjustments
  • Discord link centering
  • Media queries for hiding elements

Remove the duplicated blocks to maintain a cleaner codebase and prevent potential maintenance issues.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between daf5cf9 and 5d3daa8.

⛔ Files ignored due to path filters (3)
  • static/img/favicon.ico is excluded by !**/*.ico, !**/*.ico
  • static/img/logo/bw_coderabbit.svg is excluded by !**/*.svg, !**/*.svg
  • static/img/logo/white_coderabbit.svg is excluded by !**/*.svg, !**/*.svg
📒 Files selected for processing (2)
  • docusaurus.config.ts (1 hunks)
  • src/css/custom.css (2 hunks)
🔇 Additional comments (2)
docusaurus.config.ts (1)

169-170: LGTM! Let's verify the logo files.

The changes properly implement dark mode support with dedicated logos and follow a clear naming convention.

Let's verify that the new logo files exist in the correct locations:

✅ Verification successful

Logo files verified successfully ✓

Both logo files exist at the expected locations:

  • static/img/logo/bw_coderabbit.svg
  • static/img/logo/white_coderabbit.svg
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the existence of the new logo files
# Expected: Both logo files should exist in the static/img/logo/ directory

echo "Checking for logo files..."
fd -t f "bw_coderabbit.svg|white_coderabbit.svg" static/

Length of output: 192

src/css/custom.css (1)

41-43: LGTM!

Proper application of the base font family using CSS variable.

@GurinderRawala GurinderRawala merged commit 5e765b6 into main Nov 7, 2024
4 checks passed
@GurinderRawala GurinderRawala deleted the new-theme-colors-and-logo-c branch November 7, 2024 16:17
This was referenced Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant