Skip to content
This repository was archived by the owner on Mar 6, 2024. It is now read-only.

Max files #84

Merged
merged 9 commits into from
Mar 24, 2023
Merged

Max files #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d2cc649
separate config for max files to summarize and review
harjotgill Mar 24, 2023
a3795f3
separate config for max files to summarize and review
harjotgill Mar 24, 2023
326b36e
separate config for max files to summarize and review
harjotgill Mar 24, 2023
d4bbd28
separate config for max files to summarize and review
harjotgill Mar 24, 2023
7f94d0a
separate config for max files to summarize and review
harjotgill Mar 24, 2023
0befc24
all setting no limits to max files
harjotgill Mar 24, 2023
2ccd3b1
merge
harjotgill Mar 24, 2023
21fe1d8
all setting no limits to max files
harjotgill Mar 24, 2023
bc880a2
allow setting no limits to max files
harjotgill Mar 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ inputs:
required: false
description:
'Max files to summarize. Less than or equal to 0 means no limit.'
default: '60'
default: '40'
max_files_to_review:
required: false
description: 'Max files to review. Less than or equal to 0 means no limit.'
default: '180'
default: '0'
review_comment_lgtm:
required: false
description: 'Leave comments even if the patch is LGTM'
Expand Down
11 changes: 5 additions & 6 deletions dist/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,8 +207,8 @@ export class Options {

constructor(
debug: boolean,
max_files_to_summarize = '60',
max_files_to_review = '180',
max_files_to_summarize = '40',
max_files_to_review = '0',
review_comment_lgtm = false,
path_filters: string[] | null = null,
system_message = '',
Expand Down
13 changes: 8 additions & 5 deletions src/review.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,10 @@ export const codeReview = async (
const summaryPromises = []
const skipped_files_to_summarize = []
for (const [filename, file_content, file_diff] of files_to_review) {
if (summaryPromises.length < options.max_files_to_summarize) {
if (
options.max_files_to_summarize <= 0 ||
summaryPromises.length < options.max_files_to_summarize
) {
summaryPromises.push(
openai_concurrency_limit(async () =>
generateSummary(filename, file_content, file_diff)
Expand Down Expand Up @@ -403,9 +406,6 @@ ${
}

// Use Promise.all to run file review processes in parallel
// rewrite this to take max_files_to_review limit into account
// const reviewPromises = files_to_review.map(
// async ([filename, file_content, file_diff, patches]) =>
// openai_concurrency_limit(async () =>
// review(filename, file_content, file_diff, patches)
// )
Expand All @@ -418,7 +418,10 @@ ${
file_diff,
patches
] of files_to_review) {
if (reviewPromises.length < options.max_files_to_review) {
if (
options.max_files_to_review <= 0 ||
reviewPromises.length < options.max_files_to_review
) {
reviewPromises.push(
openai_concurrency_limit(async () =>
review(filename, file_content, file_diff, patches)
Expand Down