Skip to content
This repository was archived by the owner on Mar 6, 2024. It is now read-only.

Fix tokens calculation & cleanup the file summary prompt logic #426

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Fix tokens calculation & cleanup the file summary prompt logic #426

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07271f0
Fix tokens calculation & cleanup the file summary prompt logic
HyunggyuJang Aug 9, 2023
e697ac9
Merge branch 'main' into refactor/file-summaries
harjotgill Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions src/review.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,26 +320,22 @@ ${
}

ins.filename = filename
ins.fileDiff = fileDiff

// render prompt based on inputs so far
let tokens = getTokenCount(
prompts.renderSummarizeFileDiff(ins, options.reviewSimpleChanges)
)
const summarizePrompt = prompts.renderSummarizeFileDiff(ins, options.reviewSimpleChanges)
let tokens = getTokenCount(summarizePrompt)

const diffTokens = getTokenCount(fileDiff)
if (tokens + diffTokens > options.lightTokenLimits.requestTokens) {
if (tokens > options.lightTokenLimits.requestTokens) {
info(`summarize: diff tokens exceeds limit, skip ${filename}`)
summariesFailed.push(`${filename} (diff tokens exceeds limit)`)
return null
}

ins.fileDiff = fileDiff
tokens += fileDiff.length

// summarize content
try {
const [summarizeResp] = await lightBot.chat(
prompts.renderSummarizeFileDiff(ins, options.reviewSimpleChanges),
summarizePrompt,
{}
)

Expand Down