Skip to content
This repository was archived by the owner on Mar 6, 2024. It is now read-only.

change diff format #132

Merged
merged 20 commits into from
Apr 7, 2023
Merged

change diff format #132

merged 20 commits into from
Apr 7, 2023

Conversation

harjotgill
Copy link
Contributor

@harjotgill harjotgill commented Apr 7, 2023

Summary by OpenAI

Release Notes:

  • New Feature: Changes the format of review comments in GitHub to include line number ranges and markdown formatting for text and code snippets. Reviewers can now provide more thorough feedback on potential issues or improvements.
  • Refactor: Changes the terminology from "patches" to "hunks" in src/review.ts and modifies the code accordingly. It also adds a check for comment chain tokens and skips sending if too long.

"Code reviews made better,
With line numbers and markdown formatting galore.
Patches are now hunks,
And comment chains won't be a bore."

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2023

🤖 OpenAI

Thank you for letting me participate in the code review. I have reviewed the changes made in this pull request and have generated a summary of the changes below.

Overall, this pull request modifies the format of review comments in GitHub to include line number ranges and markdown formatting for text and code snippets. This change is expected to improve the quality of feedback provided by reviewers.

Here is a table summarizing the changes made to each file:

File Summary
action.yml Changes the format of review comments for a file in GitHub to include line number ranges and markdown formatting for text and code snippets. Reviewers are expected to provide thorough feedback on potential issues or improvements.
src/commenter.ts Changes the format of review comments in commenter.ts to include a range of lines instead of just one line. It also updates the filtering logic for existing comments.
src/review.ts Changes the terminology from "patches" to "hunks" in src/review.ts and modifies the code accordingly. It also adds a check for comment chain tokens and skips sending if too long.

Once again, thank you for allowing me to assist with this code review.


Chat with 🤖 OpenAI Bot (@openai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @openai in a reply.

Files ignored due to filter (1)

Ignored files

  • dist/index.js

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2023

🤖 OpenAI

Thank you for letting me participate in the code review. After reviewing the changes, I have generated a summary of the modifications made to the codebase.

The pull request introduces changes to the format of review comments and diff display in GitHub. The new format includes line number ranges and fenced code blocks for code snippets, which should make it easier for reviewers to provide thorough feedback on potential issues or improvement suggestions. Additionally, the diff display now shows hunks instead of patches, and file content includes line numbers. Comment chains are skipped if they exceed token limits.

Here is a table summarizing the changes made to each file:

File Summary
action.yml Changes the format of review comments to include line number ranges and fenced code blocks for code snippets.
src/commenter.ts Changes the format of review comments to include a range of lines instead of just one line. Adds logging statements for debugging purposes.
src/review.ts Changes the diff format to display hunks instead of patches. Adds line numbers to file content. Skips sending comment chains if they exceed token limits.

Overall, these changes should improve the review process by providing more context and making it easier to identify and address issues.


Chat with 🤖 OpenAI Bot (@openai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @openai in a reply.

Files ignored due to filter (1)

Ignored files

  • dist/index.js

@harjotgill harjotgill merged commit 6f25501 into main Apr 7, 2023
@harjotgill harjotgill deleted the hunks branch April 7, 2023 22:51
shoyuf pushed a commit to maybeLab/openai-mr-reviewer-gltlab that referenced this pull request Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant