fix(query-core, vue-query): fix type inference in `setQueryData` when used in functions with explicit return types #1

arvi18 · 2025-04-16T08:57:21Z

Applied the NoInfer utility type to the return type of setQueryData to prevent the outer function's return type from affecting the updater function's type inference.

closes TanStack#9024

…nctions

…ctions

arvi18 · 2025-04-16T08:57:22Z

View your CI Pipeline Execution ↗ for commit 7c34847.

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	❌ Failed	4m 21s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	2m 3s	View ↗

☁️ Nx Cloud last updated this comment at 2025-04-16 03:26:06 UTC

arvi18 · 2025-04-16T08:57:23Z

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9030

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9030

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9030

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9030

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9030

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9030

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9030

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9030

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9030

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9030

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9030

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9030

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9030

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9030

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9030

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9030

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9030

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9030

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9030

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9030

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9030

commit: 7c34847

arvi18 · 2025-04-16T08:57:24Z

The CI test failure seems unrelated to the changes in this PR. My changes only affect TypeScript type definitions and a type test, with no runtime behavior modifications. The failure appears to be in an unrelated test.

visz11 · 2025-04-23T08:07:24Z

@coderabbitai full review

coderabbitai · 2025-04-23T08:07:30Z

✅ Actions performed

Full review triggered.

coderabbitai · 2025-04-23T08:07:33Z

Warning

Rate limit exceeded

@visz11 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 20 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 4a5990e and 7c34847.

📒 Files selected for processing (4)

packages/query-core/src/__tests__/queryClient.test-d.tsx (2 hunks)
packages/query-core/src/queryClient.ts (1 hunks)
packages/vue-query/src/__tests__/queryClient.test-d.ts (1 hunks)
packages/vue-query/src/queryClient.ts (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

custardcream98 added 4 commits April 16, 2025 11:53

fix(query-core): fix setQueryData type inference in typed contexts

775d072

test(query-core): add test case for setQueryData type inference in fu…

53a2d79

…nctions

fix(vue-query): fix setQueryData type inference in typed contexts

b5c6dde

test(vue-query): add test case for setQueryData type inference in fun…

7c34847

…ctions

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(query-core, vue-query): fix type inference in `setQueryData` when used in functions with explicit return types #1

fix(query-core, vue-query): fix type inference in `setQueryData` when used in functions with explicit return types #1

arvi18 commented Apr 16, 2025

arvi18 commented Apr 16, 2025

arvi18 commented Apr 16, 2025

arvi18 commented Apr 16, 2025

visz11 commented Apr 23, 2025

coderabbitai bot commented Apr 23, 2025

coderabbitai bot commented Apr 23, 2025

Rate limit exceeded

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

fix(query-core, vue-query): fix type inference in setQueryData when used in functions with explicit return types #1

Are you sure you want to change the base?

fix(query-core, vue-query): fix type inference in setQueryData when used in functions with explicit return types #1

Conversation

arvi18 commented Apr 16, 2025

arvi18 commented Apr 16, 2025

arvi18 commented Apr 16, 2025

arvi18 commented Apr 16, 2025

visz11 commented Apr 23, 2025

coderabbitai bot commented Apr 23, 2025

coderabbitai bot commented Apr 23, 2025

Rate limit exceeded

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

fix(query-core, vue-query): fix type inference in `setQueryData` when used in functions with explicit return types #1

fix(query-core, vue-query): fix type inference in `setQueryData` when used in functions with explicit return types #1

CodeRabbit Configuration File (`.coderabbit.yaml`)