forked from apache/kafka
-
Notifications
You must be signed in to change notification settings - Fork 0
KAFKA-19173: Add Feature for "streams" group
#5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arvi18
wants to merge
1
commit into
trunk
Choose a base branch
from
clone-kafka-19173-kip-1071-feature-flag
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79 changes: 79 additions & 0 deletions
79
server-common/src/main/java/org/apache/kafka/server/common/StreamsGroupVersion.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.kafka.server.common; | ||
|
|
||
| import java.util.Map; | ||
|
|
||
| public enum StreamsGroupVersion implements FeatureVersion { | ||
|
|
||
| // Version 0 does disable "streams" groups (KIP-1071). | ||
| SGV_0(0, MetadataVersion.MINIMUM_VERSION, Map.of()), | ||
|
|
||
| // Version 1 enables "streams" groups (KIP-1071). | ||
| SGV_1(1, MetadataVersion.IBP_4_1_IV2, Map.of()); | ||
|
|
||
| public static final String FEATURE_NAME = "streams.group.version"; | ||
|
|
||
| // Disabled by default in 4.1 (early access only). | ||
| public static final StreamsGroupVersion LATEST_PRODUCTION = SGV_0; | ||
|
|
||
| private final short featureLevel; | ||
| private final MetadataVersion bootstrapMetadataVersion; | ||
| private final Map<String, Short> dependencies; | ||
|
|
||
| StreamsGroupVersion( | ||
| int featureLevel, | ||
| MetadataVersion bootstrapMetadataVersion, | ||
| Map<String, Short> dependencies | ||
| ) { | ||
| this.featureLevel = (short) featureLevel; | ||
| this.bootstrapMetadataVersion = bootstrapMetadataVersion; | ||
| this.dependencies = dependencies; | ||
| } | ||
|
|
||
| @Override | ||
| public short featureLevel() { | ||
| return featureLevel; | ||
| } | ||
|
|
||
| @Override | ||
| public String featureName() { | ||
| return FEATURE_NAME; | ||
| } | ||
|
|
||
| @Override | ||
| public MetadataVersion bootstrapMetadataVersion() { | ||
| return bootstrapMetadataVersion; | ||
| } | ||
|
|
||
| @Override | ||
| public Map<String, Short> dependencies() { | ||
| return dependencies; | ||
| } | ||
|
|
||
| public boolean streamsGroupSupported() { | ||
| return featureLevel >= SGV_1.featureLevel; | ||
| } | ||
|
|
||
| public static StreamsGroupVersion fromFeatureLevel(short version) { | ||
| return switch (version) { | ||
| case 0 -> SGV_0; | ||
| case 1 -> SGV_1; | ||
| default -> throw new RuntimeException("Unknown streams group feature level: " + (int) version); | ||
| }; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix typo in feature name in error message.
There's a typo in the feature name included in the error message: "streams.group.featrue" should be "streams.group.version" to match the actual feature name used elsewhere in the codebase.
📝 Committable suggestion