-
-
Notifications
You must be signed in to change notification settings - Fork 6
try to add a document_symbols handler #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'll check the PR later today. Thanks for the contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also update Readme with checklist for this support.
thanks for the notes! will prob be a few days before i get back to this |
I did have one other question that feels very "Man I haven't written enough rust" -- The lsp types struct for document symbols doesn't have any constructors/default implementation that I can find, but marks one if its fields deprecated. is there any way to avoid this:
|
Head branch was pushed to by a user without write access
Best we can do is to suppress that deprecated struct initialisation using |
We can probably leverage DocumentSymbol for other operation such as goto-def, hover etc. But that is out of your PR's scope so I let that go for now. |
started using this the lsp the other day and found it very helpful to jump from message-to-message. thanks!
i use https://github.com/hedyhli/outline.nvim and work with some massive proto files, so i thought it might be nice to be able to get an outline of the file in the outline view.
i'm not an expert with treesitter node walking nor language servers so there are probably several optimizations that could be made.
not sure if there's interest in this but I figured i would post it anyway.