Skip to content

fix: Do not emit pkg config metadata in pkg-config #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 26, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[package]
name = "protols"
description = "Language server for proto3 files"
version = "0.11.0"
version = "0.11.1"
edition = "2024"
license = "MIT"
homepage = "https://github.com/coder3101/protols"
Expand Down
3 changes: 0 additions & 3 deletions protols.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,2 @@
[config]
include_paths = ["src/workspace/input"]

[config.experimental]
use_protoc_diagnostics = true
4 changes: 4 additions & 0 deletions src/config/workspace.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,12 @@ pub struct WorkspaceProtoConfigs {
impl WorkspaceProtoConfigs {
pub fn new() -> Self {
// Try to find protobuf library and get its include paths
// Do not emit metadata on stdout as LSP programs can consider
// it part of spec
let protoc_include_prefix = Config::new()
.atleast_version("3.0.0")
.env_metadata(false)
.cargo_metadata(false)
.probe("protobuf")
.map(|lib| lib.include_paths)
.unwrap_or_default();
Expand Down