Skip to content

Add VSCODE_PROXY_URI environment variable #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add VSCODE_PROXY_URI environment variable #3

wants to merge 3 commits into from

Conversation

code-asher
Copy link
Member

@code-asher
Add resolver environment to extension host
80518ae 
These actually appear unused but we will be making use of them for the
proxy URI environment variable.
@code-asher
Add VSCODE_PROXY_URI to terminal environment
42dfa57
@code-asher
Add VSCODE_PROXY_URI to resolver environment
3bed399 
Closes coder/code-server#1510.

This environment passes down to terminals and extension hosts.
@code-asher code-asher mentioned this pull request Sep 29, 2021
Closed
4 tasks
jsjoeio
jsjoeio approved these changes Sep 29, 2021
View reviewed changes
Copy link

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@code-asher
Copy link
Member Author

code-asher commented Sep 29, 2021 •
edited
Loading

Ah one sec, the other branch is pulling in the wrong commit since I rebased so I need to switch to make sure it is testing and passes.

@code-asher code-asher marked this pull request as draft September 29, 2021 20:16
@GirlBossRush
Copy link

@code-asher I’ve merged your fork changes which should make this easier to rebase. I recommend setting the vendor package.json commit to ac74ac1220ad3016159c65ed5d6581ab88ab43be or later.

@code-asher code-asher closed this Oct 1, 2021
@code-asher code-asher deleted the vscode-proxy-uri branch October 1, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsjoeio jsjoeio jsjoeio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@code-asher @GirlBossRush @jsjoeio