Fix images not loading #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsjoeio
approved these changes
Dec 14, 2021
|
Hmm yeah I was not completely sure what to put here. I tested Codespaces and theirs works because they use a CDN and there is special logic for adding the CDN to the CSP. But for instances serving the extension from the same host it fails. I am not sure if this is technically a bug but it seems to be? I should mark this change so we can find it more easily and I will add some kind of note. |
|
Actually adding this to that spot would be a better fix, one sec. |
|
Yeah I think this is better because then you can see the change in contrast with the CDN code so it might make more sense why we have to add self. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coder/code-server#3410