Skip to content

Make relative paths work at any depth #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2021
Merged

Make relative paths work at any depth #24

merged 1 commit into from
Dec 8, 2021

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Dec 8, 2021 •
edited
Loading

Part 1 of coder/code-server#4503 (and also fixes other paths like static resources and webviews).

@code-asher code-asher requested a review from jsjoeio December 8, 2021 19:10
jsjoeio
jsjoeio approved these changes Dec 8, 2021
View reviewed changes
Copy link

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks relatively straightforward - nice work! 🙌

I see this is Part 1. How many parts are left?

@code-asher code-asher merged commit 478224a into coder:main Dec 8, 2021
@code-asher code-asher deleted the relative-paths branch December 8, 2021 19:55
@code-asher
Copy link
Member Author

One more part, the matching PR on the code-server side 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsjoeio jsjoeio jsjoeio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@code-asher @jsjoeio