Fix issues surrounding persisted workspaces. #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GirlBossRush
added
bug
GirlBossRush
force-pushed
the
4487-last-opened
branch
from
c149443 to
f97ca76
Compare
jsjoeio
reviewed
Nov 18, 2021
src/vs/workbench/browser/web.main.ts
Outdated
| const folder = toWorkspaceFolder(recent.folderUri); | ||
| workspace.folders = [folder]; | ||
|
|
||
| window.history.replaceState(null, '', `?folder=${encodePath(folder.uri.path)}`); |
There was a problem hiding this comment.
❓ Does this mean that if you open localhost:8080 (without passing a folder via the CLI), it will check for a recent folder and then append that as a query param to the URL?
(followup: what's the reason for doing this? Is this so the open folder is always in the URL or something else)
There was a problem hiding this comment.
Correct. This ensures the user gets a URL which matches the format generated by VS Code when they explicitly open a new folder. It also lets them share a link to a specific folder which is especially useful now that this state is stored in the browser.
- Moved URI helper.
GirlBossRush
force-pushed
the
4487-last-opened
branch
from
f97ca76 to
5b733b1
Compare
jsjoeio
approved these changes
Nov 19, 2021
This was referenced Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses coder/code-server#4487, specifically extending VS Code’s existing desktop workspace behaviors to the browser. This may also address
—ignore-last-openedby making the new tab behavior match the user’s initial path arguments.https://github.com/cdr/vscode/blob/c1494438479e8382794576f2c621081d52b4fdc1/src/vs/workbench/browser/web.main.ts#L223-L243