Skip to content

Commit 3fc8859

Browse files
author
Teffen
authored
Merge pull request #7 from code-asher/fix-build
Fix missing files
2 parents 8148759 + 10c042e commit 3fc8859

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

build/gulpfile.vscode.server.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,11 @@ const REPO_ROOT = path.dirname(__dirname);
3030
const commit = util.getVersion(REPO_ROOT);
3131
const BUILD_ROOT = path.dirname(REPO_ROOT);
3232

33-
// Put files here that need to be packaged that are not already in the entry
34-
// points or included by the entry points. The optimize step bundles code into
35-
// each entry point that imports it but more interestingly adding files here
36-
// that would normally get bundled causes the bundling to fail resulting in
37-
// "multiple top-level define" errors from the loader.
33+
// Put files here that need to be packaged that are not entry points or imported
34+
// by an entry point. The optimize step bundles each entry point into a single
35+
// file and for some reason adding files here that would normally get bundled
36+
// causes them (and their imports) not to get bundled. In the worst case this
37+
// can cause multiple top-level define errors, other times it causes 404s.
3838
const vscodeServerResources = [
3939
// Bootstrap
4040
'out-build/main.js',

0 commit comments

Comments
 (0)