Skip to content

Commit 10c042e

Browse files
committed
Improve comment on resources array
1 parent 4d0dc1b commit 10c042e

File tree

1 file changed

+9
-11
lines changed

1 file changed

+9
-11
lines changed

build/gulpfile.vscode.server.js

+9-11
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,11 @@ const REPO_ROOT = path.dirname(__dirname);
3030
const commit = util.getVersion(REPO_ROOT);
3131
const BUILD_ROOT = path.dirname(REPO_ROOT);
3232

33-
// Put files here that need to be packaged that are not already in the entry
34-
// points or included by the entry points. The optimize step bundles code into
35-
// each entry point that imports it but more interestingly adding files here
36-
// that would normally get bundled causes the bundling to fail resulting in
37-
// "multiple top-level define" errors from the loader.
33+
// Put files here that need to be packaged that are not entry points or imported
34+
// by an entry point. The optimize step bundles each entry point into a single
35+
// file and for some reason adding files here that would normally get bundled
36+
// causes them (and their imports) not to get bundled. In the worst case this
37+
// can cause multiple top-level define errors, other times it causes 404s.
3838
const vscodeServerResources = [
3939
// Bootstrap
4040
'out-build/main.js',
@@ -48,12 +48,10 @@ const vscodeServerResources = [
4848
'out-build/bootstrap-window.js',
4949

5050
// Base
51-
'out-build/vs/base/common/performance.js',
52-
'out-build/vs/base/node/languagePacks.js',
53-
'out-build/vs/base/node/{stdForkStart.js,terminateProcess.sh,cpuUsage.sh,ps.sh}',
54-
'out-build/vs/base/browser/ui/codicons/codicon/**',
55-
'out-build/vs/base/parts/sandbox/electron-browser/preload.js',
56-
'out-build/vs/platform/environment/node/userDataPath.js',
51+
'out-build/vs/base/**/*',
52+
53+
// Platform
54+
'out-build/vs/platform/**/*',
5755

5856
// Workbench
5957
'out-build/vs/code/browser/workbench/service-worker.js',

0 commit comments

Comments
 (0)