feat: validate ssh properties before launching workspaces #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
May 4, 2023
src/remote.ts
Outdated
| { | ||
| useCustom: true, | ||
| modal: true, | ||
| detail: `Your SSH config is overriding the "${key}=${computedProperties[key]}" option for the "${hostName}" host. Please remove it and try again!`, |
There was a problem hiding this comment.
We could add "overriding the key=correct with key=wrong ..." to help trace the issue?
src/sshSupport.ts
Outdated
| if (line === "") { | ||
| return | ||
| } | ||
| const [key, ...valueParts] = line.split(/\s+/) |
There was a problem hiding this comment.
Ahh, great point! I'll add a test case.
This was reported by a member in Discord, and displayed a poor error by VS Code when it failed before. Users cannot override our config options otherwise connections may fail or have unexpected behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was reported by a member in Discord, and displayed a poor error by VS Code when it failed before.
Users cannot override our config options otherwise connections may fail or have unexpected behavior.