WIP: feat: crud workspaces #72
Conversation
BrunoQuaresma
requested review from
a team and
BrunoQuaresma
and removed request for
a team
rodrimaia
force-pushed
the
crud-workspaces
branch
from
f29dd17 to
4024189
Compare
|
I see some plugins asking to confirm the "name" of the thing you want to delete. Probably we want to do the same. What do you think? |
|
| if (agents.length === 1) { | ||
| folderPath = agents[0].expanded_directory | ||
| } |
There was a problem hiding this comment.
If there is more than 1 agent, does everything fail? Should we randomly choose one?
There was a problem hiding this comment.
That is a good question. I am not changing the actual behavior, just extracted it to a new function. the current version also does this agents[0] choice =/ . I am not sure what is the best way to handle multiple agents...
| if (user.roles.find((role) => role.name === "owner")) { | ||
| await vscode.commands.executeCommand("setContext", "coder.isOwner", true) | ||
| } |
There was a problem hiding this comment.
Why do we need to check for the owner role? We prefer to do capability checks. You can send a payload to https://dev.coder.com/api/v2/authcheck to see if you can do something. Eg:
{
"checks":{
"readAllUsers":{
"object":{
"resource_type":"user"
},
"action":"read"
},
},
}Is this just to see if we have arbitrary execution of all workspaces?
There was a problem hiding this comment.
I think this is ok for now, we but we might want to change this soon, especially with coder/coder#6875
There was a problem hiding this comment.
We decided to only show the "all Workspaces" view for users who have the owner role. sure we can revisit this after the owner connections PR
#64
https://www.loom.com/share/269af08124544e81a5e58471ffe2a67c