feat: Add feature to allow config-ssh value overrides #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
commented
Mar 23, 2023
src/remote.ts
Outdated
Comment on lines
458
to
469
| case 401: { | ||
| const result = await this.vscodeProposed.window.showInformationMessage( | ||
| "Your session expired...", | ||
| { | ||
| useCustom: true, | ||
| modal: true, | ||
| detail: "You must login again to access your workspace.", | ||
| }, | ||
| "Login", | ||
| ) | ||
| throw error | ||
| } |
There was a problem hiding this comment.
What is the best way to handle this?
There was a problem hiding this comment.
This just throws some error if there is an unauthorized response code. It shouldn't happen because we are logged in, so it's an edge case that we don't need to handle all too well?
|
Fixes coder/coder#6826 |
kylecarbs
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also supports unsetting ssh config options.