Fix version comparison logic for checking wildcard support in "coder ssh" #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssh" This meant to check that the version was at least 2.19.0, but the logic was faulty.
|
Ah damn thanks for the fix on that. The version check on proxyLogDirectory is a bit misleading with it being released in 1.3.2. I wonder if I should back port this as a patch 🤔 tbh I think most everyone auto updates, even to major versions. |
bcpeinhardt
approved these changes
Mar 7, 2025
|
Fortunately it's a harmless error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This meant to check that the version was at least 2.19.0, but the logic was faulty.