Skip to content

fix: set usage-app to vscode on coder ssh #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 4, 2025
Merged

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Mar 3, 2025

Closes coder/coder#16746

Full credit to Asher for noticing why this broke!

I haven't tested this with the actual vscode extension, but the counter on the dashboard did increment after running coder ssh <ws> --usage-app=vscode, and I was unable to get it to increment otherwise.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ethanndickson ethanndickson marked this pull request as ready for review March 3, 2025 06:01
Copy link
Collaborator

@bcpeinhardt bcpeinhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😎 Mind adding a snippet to the Unreleased section of the Changelog? After that it's good to go for me :)

@ethanndickson
Copy link
Member Author

All done! Though I don't have perms to merge, so you'll need to do that for me

@bcpeinhardt bcpeinhardt merged commit 01df482 into main Mar 4, 2025
3 checks passed
@bcpeinhardt bcpeinhardt deleted the ethan/set-usage-app branch March 4, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VSCode session counts on dashboard not getting populated
2 participants