Skip to content

Add option to disable downloads #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2024
Merged

Add option to disable downloads #263

merged 1 commit into from
May 14, 2024

Conversation

code-asher
Copy link
Member

Closes #193

@code-asher code-asher requested a review from Parkreiner May 10, 2024 19:26
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to go through the VSCode docs a little to see how things are set up, but the changes seem straightforward and make sense to me!!

Comment on lines +66 to +70
"coder.enableDownloads": {
"markdownDescription": "Allow the plugin to download the CLI when missing or out of date.",
"type": "boolean",
"default": true
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still trying to get up to speed on VS Code extension stuff. I think I get the point of the contribution point properties, but aside from the default values, how do these properties get set over time?

Looks like it's strictly the config.update method?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, you can update it with config.update() from plugin code, although we have no need to update it ourselves in this case, we just let it get set via the settings window (which is presumably using config.update()).

Funny thing about the default is that it seems to have no actual effect on the code, it only changes what is displayed in the settings window. In the code you just get undefined.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically you could also munge the settings.json file and VS Code will pick that up but that is a pretty janky way to update a value. I have seen it done though although I forget why.

@code-asher code-asher merged commit a6e43e9 into main May 14, 2024
2 checks passed
@code-asher code-asher deleted the asher/disable-download branch May 14, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to disable downloading Coder binary even if out of date or missing
2 participants